Wireshark-commits: [Wireshark-commits] master 67bef4c: RTP/RTCP: remove port number check from heur
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 20 Jul 2020 04:35:12 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=67bef4c24e87281a9af2cdbb77425aa7d0198446
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

67bef4c by Nardi Ivan (nardi.ivan@xxxxxxxxx):

    RTP/RTCP: remove port number check from heuristics
    
    As per RFC 3550, "RTP SHOULD use an even destination port number and
    the corresponding RTCP stream SHOULD use the next higher (odd) destination
    port number".
    However, nowadays, RTP and RTCP packets are often multiplexed onto a single
    port, for the reasons explained in RFC 5761, so the port number might be
    completely random.
    WEBRTC connections are a classic example of this kind of deployment.
    Therefore, remove port check in RTP/RTCP over UDP heuristics.
    Note that RTP/RTCP heuristics over Stun are already correctly avoiding
    checking the port number.
    
    Change-Id: Ib63036954c5188936de8b38b0af146eb4bcde0ca
    Reviewed-on: https://code.wireshark.org/review/37903
    Petri-Dish: Martin Kaiser <wireshark@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  08b3414   RTPS: catch another use of an uninitialized structure member.
     add  67bef4c   RTP/RTCP: remove port number check from heuristics


Summary of changes:
 epan/dissectors/packet-rtcp.c | 14 +-------------
 epan/dissectors/packet-rtp.c  | 25 ++++---------------------
 2 files changed, 5 insertions(+), 34 deletions(-)