Wireshark-commits: [Wireshark-commits] master b15ebdf: rlcmac: Decode properly Pkt Ul ACK/NACK R99
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=b15ebdf0ab423c2f1fdd233e02d4498baa94096e
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark
Commits:
b15ebdf by Pau Espin Pedrol (pespin@xxxxxxxxxxx):
rlcmac: Decode properly Pkt Ul ACK/NACK R99 Additions
First, remove the unnecessary M_UNION there, and handle Fixed Allocation
Parameters are per older version of spec TS 44.060 with usual presence
bit + struct. The coding of the struct is left unimplemented as an
exercise for someone needing it in the future (since it's not supposed
to be used by current specs anyway).
Once this is cleared up, the rest of the message (Release 99 Additions)
are parsed fine.
Tested with a pcap trace containing a Pkt Ul ACK/NACK with R99 additions
and TBF_EST inside it.
CSN.1 Reference: 3GPP TS 44.060 Table 11.2.28.1
Change-Id: Ie22e99abdbc2bb3988e7a1930d459ba810a348ac
Reviewed-on: https://code.wireshark.org/review/37776
Petri-Dish: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
Tested-by: Petri Dish Buildbot
Reviewed-by: Vadim Yanitskiy <vyanitskiy@xxxxxxxxxxx>
Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
Actions performed:
from e1df757 Qt: Improve status bar messages
add b15ebdf rlcmac: Decode properly Pkt Ul ACK/NACK R99 Additions
Summary of changes:
epan/dissectors/packet-gsm_rlcmac.c | 19 +++++++++----------
epan/dissectors/packet-gsm_rlcmac.h | 18 +++++++++++-------
2 files changed, 20 insertions(+), 17 deletions(-)
