Wireshark · Wireshark-commits: [Wireshark-commits] master e483519: extcap: clean up the version number handling.

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=e4835191cb72d3235b8e4fb3b7f66c09edb7aa44
Submitter: "Guy Harris <gharris@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

e483519 by Guy Harris (gharris@xxxxxxxxx):

    extcap: clean up the version number handling.
    
    Have the version parameter be just the version number; other code
    expects it to be that.
    
    Have additional parameters for the "compiled with" and "running with"
    information.
    
    Add a extcap_version_print() routine to show the version message,
    printing
    
    	{exename} version {version}
    
    and then printing
    
    	Compiled with {compiled_with}
    
    if "compiled with" information is supplied and printing
    
    	Running with {running_with}
    
    if "running with" information is supplied.
    
    This fixes some messages, as well as fixing the display of extcap
    modules in the About dialog.
    
    Change-Id: I3d298d30e83bd363abd599d75adfc780a90f34fd
    Reviewed-on: https://code.wireshark.org/review/37877
    Petri-Dish: Guy Harris <gharris@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Guy Harris <gharris@xxxxxxxxx>
    

Actions performed:

    from  44ca0af   extcap-base: no need to get the basename of the executable path twice.
     add  e483519   extcap: clean up the version number handling.


Summary of changes:
 extcap/androiddump.c |  2 +-
 extcap/ciscodump.c   |  8 ++++----
 extcap/dpauxmon.c    |  2 +-
 extcap/extcap-base.c | 32 +++++++++++++++++++++++---------
 extcap/extcap-base.h |  6 +++++-
 extcap/randpktdump.c |  2 +-
 extcap/sdjournal.c   |  2 +-
 extcap/sshdump.c     |  8 ++++----
 extcap/udpdump.c     |  2 +-
 9 files changed, 41 insertions(+), 23 deletions(-)