Wireshark-commits: [Wireshark-commits] master 00b5c28: Sort list of available filetypes when loadin
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 14 Jul 2020 16:25:25 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=00b5c2809ac747982c4cb0390ed3988097c8bc7d
Submitter: "Gerald Combs <gerald@xxxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

00b5c28 by David Perry (boolean263@xxxxxxxxxxxxxx):

    Sort list of available filetypes when loading a capture
    
    When loading a capture file in the GUI, this change causes the list of
    available file types to be sorted alphabetically. "Automatically detect
    file type", pcap, and pcapng remain at the top of the list.
    
    Unlike my prior crack at this in change #36862, this is done directly in
    the file open dialogs (open_file_hook_proc() for Windows,
    CaptureFileDialog::addFormatTypeSelector() and CaptureFileDialog::open()
    for Qt). No changes to wiretap.
    
    It's not a huge deal if you folks decide this isn't necessary, I just
    think this gives a bit of extra polish to the load-file dialog. It also
    makes it easier for the user to spot the format they want if they aren't
    aware that the file-format dropdown accepts keyboard input.
    
    Change-Id: Ie81c6d99e83fe862f20b413318ac8ce76463a766
    Reviewed-on: https://code.wireshark.org/review/37749
    Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    

Actions performed:

    from  d8db04b   Windows: upgrade Npcap to 0.9995
     add  00b5c28   Sort list of available filetypes when loading a capture


Summary of changes:
 ui/qt/capture_file_dialog.cpp | 16 ++++++++++++++--
 ui/win32/file_dlg_win32.c     | 37 ++++++++++++++++++++++++++++++++++++-
 2 files changed, 50 insertions(+), 3 deletions(-)