Wireshark-commits: [Wireshark-commits] master 32a804d: kafka: snappy: free the composite tvb only o
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 13 Jul 2020 05:12:20 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=32a804dea2b6d657b581f5e5e14585099c53ddbe
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

32a804d by Martin Kaiser (wireshark@xxxxxxxxx):

    kafka: snappy: free the composite tvb only once
    
    The snappy decompression routine has the same bug that was fixed for lz4 in
    79576219c9 ("kafka: lz4: free the composite tvb only once").
    
    Refactor the composite tvb handling for snappy as well. Allocate the
    composite tvb only if we are cetain that data will be added to it.
    Do not free the composite tvb ourselves, leave this to epan cleanup.
    
    Change-Id: Ide3a88d1c02e525fe1aadd176068ce68c2330b98
    Reviewed-on: https://code.wireshark.org/review/37838
    Reviewed-by: Martin Kaiser <wireshark@xxxxxxxxx>
    Petri-Dish: Martin Kaiser <wireshark@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  a71ecfa   QUIC: add GREASE QUIC Bit Transport Parameter
     add  32a804d   kafka: snappy: free the composite tvb only once


Summary of changes:
 epan/dissectors/packet-kafka.c | 19 ++++++++++---------
 1 file changed, 10 insertions(+), 9 deletions(-)