Wireshark-commits: [Wireshark-commits] master 455a479: USB: Add a size check.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 9 Jul 2020 06:21:02 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=455a4794d810529313c900828fff1b097a363a50
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

455a479 by Gerald Combs (gerald@xxxxxxxxxxxxx):

    USB: Add a size check.
    
    In dissect_usbpcap_iso_packets check for a sane isochronous packet
    count, otherwise we might overflow our data start offset.
    
    Bug: 16677
    Change-Id: I79534b4a519eefcf85cf4dd03424ac654bacd8c9
    Reviewed-on: https://code.wireshark.org/review/37789
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  4cf0923   spoolss: pick up what some printer attributes mean from Microsoft documentation.
     add  455a479   USB: Add a size check.


Summary of changes:
 epan/dissectors/packet-usb.c | 16 ++++++++++++----
 1 file changed, 12 insertions(+), 4 deletions(-)