Wireshark-commits: [Wireshark-commits] master-3.0 4674c00: tn3270: improve on some of IBM's painful
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 8 Jul 2020 20:51:15 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=4674c009b53d9c01ca83609a85b387b85df99cfc
Submitter: "Guy Harris <gharris@xxxxxxxxx>"
Changed: branch: master-3.0
Repository: wireshark

Commits:

4674c00 by Guy Harris (gharris@xxxxxxxxx):

    tn3270: improve on some of IBM's painful prose.
    
    The "true" string in a struct true_false_string is used only if the bit
    is set to 1, so "if set to logic 1" is redundant.  Just have the strings
    say, respectively, what significance the bit being on ("set to logic 1")
    has and what signficance the bit being off ("set to logic 0") has.
    
    Use active voice.
    
    Change-Id: If1fe7b35a0c85dcdb40ac348ca23a0ac5e3dc1da
    Reviewed-on: https://code.wireshark.org/review/37753
    Reviewed-by: Jaap Keuter <jaap.keuter@xxxxxxxxx>
    Reviewed-by: Guy Harris <gharris@xxxxxxxxx>
    (cherry picked from commit 6f52f969d823037aa4f24fdcedf4d9fbce22d17b)
    Reviewed-on: https://code.wireshark.org/review/37801
    

Actions performed:

    from  251f5eb   NIS+: give the meanings of the NIS_CALLBACK return value.
     add  4674c00   tn3270: improve on some of IBM's painful prose.


Summary of changes:
 epan/dissectors/packet-tn5250.c | 34 +++++++++++++++++-----------------
 1 file changed, 17 insertions(+), 17 deletions(-)