Wireshark-commits: [Wireshark-commits] master 6f52f96: tn3270: improve on some of IBM's painful pro
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 7 Jul 2020 06:45:40 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=6f52f969d823037aa4f24fdcedf4d9fbce22d17b
Submitter: "Guy Harris <gharris@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

6f52f96 by Guy Harris (gharris@xxxxxxxxx):

    tn3270: improve on some of IBM's painful prose.
    
    The "true" string in a struct true_false_string is used only if the bit
    is set to 1, so "if set to logic 1" is redundant.  Just have the strings
    say, respectively, what significance the bit being on ("set to logic 1")
    has and what signficance the bit being off ("set to logic 0") has.
    
    Use active voice.
    
    Change-Id: If1fe7b35a0c85dcdb40ac348ca23a0ac5e3dc1da
    Reviewed-on: https://code.wireshark.org/review/37753
    Reviewed-by: Jaap Keuter <jaap.keuter@xxxxxxxxx>
    Reviewed-by: Guy Harris <gharris@xxxxxxxxx>
    

Actions performed:

    from  86c27cc   USB HID: fix parsing {logical ,phys }{min,max} in the report descriptor
     add  6f52f96   tn3270: improve on some of IBM's painful prose.


Summary of changes:
 epan/dissectors/packet-tn5250.c | 34 +++++++++++++++++-----------------
 1 file changed, 17 insertions(+), 17 deletions(-)