Wireshark-commits: [Wireshark-commits] master 4dc3114: Windows: Set our locale to ".UTF-8".
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 6 Jul 2020 16:20:38 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=4dc3114c050ac2fb6da2b19103ce4995f6d91561
Submitter: "Gerald Combs <gerald@xxxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

4dc3114 by Gerald Combs (gerald@xxxxxxxxxxxxx):

    Windows: Set our locale to ".UTF-8".
    
    In each of our executables we were calling "setlocale(LC_ALL, "")" at
    startup. This told Windows that output was encoded using the current
    system code page. Unless the code page was 65001 (UTF-8), this was a lie.
    
    We write UTF-8 to stdout and stderr, so call "setlocale(LC_ALL, ".UTF-8)"
    at startup on Windows. This lets the CRT translate our output correctly
    in more cases.
    
    Clarify and expand the OUTPUT section in the tshark man page.
    
    Bug: 16649
    Change-Id: If93231fe5b332c292946c7f8e5e813e2f543e799
    Reviewed-on: https://code.wireshark.org/review/37560
    Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    

Actions performed:

    from  0d7d7fe3  rtps-utils: fix no previous prototype for functio
     add  4dc3114   Windows: Set our locale to ".UTF-8".


Summary of changes:
 capinfos.c     |  9 ++++++++-
 captype.c      |  9 ++++++++-
 dftest.c       |  9 ++++++++-
 doc/tshark.pod |  7 +++++--
 rawshark.c     |  9 ++++++++-
 tfshark.c      |  9 ++++++++-
 tshark.c       | 13 ++++++++++---
 ui/qt/main.cpp |  9 ++++++++-
 8 files changed, 63 insertions(+), 11 deletions(-)