Wireshark-commits: [Wireshark-commits] master 9fc054a: Add all supported charsets to Show Packet By
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=9fc054a65bfadf40325bb4f5185c7247ed4a9a6c
Submitter: "Stig Bjørlykke <stig@xxxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark
Commits:
9fc054a by John Thacker (johnthacker@xxxxxxxxx):
Add all supported charsets to Show Packet Bytes/Follow Stream
Use the QT text codec support to add charset conversions for all character
encodings supported by QT to Show Packet Bytes and Follow Stream (Save As
will convert to UTF-8.) Note that this is dynamic and the exact list will
depend on the version of QT and if libicu support is enabled. This does
make the list of codecs pretty long, so hopefully it shows up well on all
the different QT styles.
This does not yet support when multibyte characters span more than one packet
in Follow Stream, though the current code doesn't do that for UTF-8 or UTF-16
already. This is probably most useful for HTTP captures.
Bug: 16137
Change-Id: I6d5cd761a5d9d914b7a787fe8eb02b07b19642e6
Ping-Bug: 16630
Reviewed-on: https://code.wireshark.org/review/37707
Petri-Dish: Stig Bjørlykke <stig@xxxxxxxxxxxxx>
Tested-by: Petri Dish Buildbot
Reviewed-by: Stig Bjørlykke <stig@xxxxxxxxxxxxx>
Actions performed:
from 23cb695 slsk: Try to fix -Wpointer-sign warnings.
add 9fc054a Add all supported charsets to Show Packet Bytes/Follow Stream
Summary of changes:
epan/follow.h | 7 ++--
ui/qt/follow_stream_dialog.cpp | 46 +++++++++++++----------
ui/qt/follow_stream_dialog.h | 1 +
ui/qt/main_window.cpp | 45 ++++++++++++++++++++++
ui/qt/main_window.h | 3 ++
ui/qt/main_window_slots.cpp | 3 +-
ui/qt/show_packet_bytes_dialog.cpp | 76 ++++++++++++++++++--------------------
ui/qt/show_packet_bytes_dialog.h | 8 ++--
8 files changed, 120 insertions(+), 69 deletions(-)
