Wireshark · Wireshark-commits: [Wireshark-commits] master 638d989: Revert "ISO14443: Update some commands"

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=638d989567d39ace5b6f0bb03d10fa67474f7db7
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

638d989 by Martin Kaiser (wireshark@xxxxxxxxx):

    Revert "ISO14443: Update some commands"
    
    This reverts commit fe8744026c5f23fac15069ea597f7e99f7072d44.
    
    The commands that fe8744026c ("ISO14443: Update some commands") adds are
    not part of iso14443. It seems that these are mifare commands.
    (There's a couple of different mifare variants, not all of them support
     those commands.)
    
    Adding the commands unconditionally breaks iso14443 dissection.
    An iso14443 block with a pcb byte of 0xA2 is an R-ACK block for block
    number 0. This is not a "write block".
    
    If we want to support mifare cards, we have to detect the card type
    during activation. We can then add a mifare dissector which handles the
    messages after activation if we are actually talking to a mifare card...
    
    Change-Id: I86164cc4c1618204641ae00566694d0f98871785
    Reviewed-on: https://code.wireshark.org/review/37689
    Reviewed-by: Martin Kaiser <wireshark@xxxxxxxxx>
    Petri-Dish: Martin Kaiser <wireshark@xxxxxxxxx>
    Petri-Dish: Anders Broman <a.broman58@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  5e05fe0   [Automatic update for 2020-07-05]
     add  638d989   Revert "ISO14443: Update some commands"


Summary of changes:
 epan/dissectors/packet-iso14443.c | 202 +++-----------------------------------
 1 file changed, 13 insertions(+), 189 deletions(-)