Wireshark-commits: [Wireshark-commits] master 26b44bd: DHCPv6: remove a redundant test.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 4 Jul 2020 21:26:28 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=26b44bd8230010c0242c0ede8e556ed27145220a
Submitter: "Martin Mathieson <martin.r.mathieson@xxxxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

26b44bd by Martin Mathieson (martin.mathieson@xxxxxxxxxxxx):

    DHCPv6: remove a redundant test.
    
    From cppcheck:
    
    epan/dissectors/packet-dhcpv6.c:2276:20: warning: Condition 'optlen>=4' is always true [knownConditionTrueFalse]
            if (optlen >= 4) {
                       ^
    epan/dissectors/packet-dhcpv6.c:2268:20: note: Assuming that condition 'optlen<4' is not redundant
            if (optlen < 4) {
                       ^
    epan/dissectors/packet-dhcpv6.c:2276:20: note: Condition 'optlen>=4' is always true
            if (optlen >= 4) {
    
    Change-Id: Ia7e83e6712afe9756735b7bede5b58914d4f06bd
    Reviewed-on: https://code.wireshark.org/review/37701
    Petri-Dish: Martin Mathieson <martin.r.mathieson@xxxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Martin Mathieson <martin.r.mathieson@xxxxxxxxxxxxxx>
    

Actions performed:

    from  f23fe3b   amqp: fix the type of elements of an array of pointers to hf_ values.
     add  26b44bd   DHCPv6: remove a redundant test.


Summary of changes:
 epan/dissectors/packet-dhcpv6.c | 28 +++++++++++++---------------
 1 file changed, 13 insertions(+), 15 deletions(-)