Wireshark-commits: [Wireshark-commits] master-3.0 befac62: Qt: Update ByteView recent settings on a
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 3 Jul 2020 08:21:56 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=befac622e45fce911a985c0bc474cf1663b0b1a2
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master-3.0
Repository: wireshark

Commits:

befac62 by Stig Bjørlykke (stig@xxxxxxxxxxxxx):

    Qt: Update ByteView recent settings on all tabs
    
    The ByteView recent settings are common for all tabs. Ensure all
    tabs are updated when display format or character encoding is changed.
    
    This fixes an issue where the row_width is wrong and the menu action
    checkmarks are out of sync after switching ByteView tab.
    
    Change-Id: Ied25ac41467143f37327ccadcb821262eb86ef0a
    Reviewed-on: https://code.wireshark.org/review/37655
    Petri-Dish: Stig Bjørlykke <stig@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Stig Bjørlykke <stig@xxxxxxxxxxxxx>
    (cherry picked from commit b8a330d2d5e8f903b9d7da8ffa79efb4e15b526f)
    Reviewed-on: https://code.wireshark.org/review/37680
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  70ed4f3   Qt: Remove ellipsis from "Disable protocol" menu item
     add  befac62   Qt: Update ByteView recent settings on all tabs


Summary of changes:
 ui/qt/byte_view_tab.cpp          |  2 +
 ui/qt/byte_view_tab.h            |  1 +
 ui/qt/widgets/byte_view_text.cpp | 93 ++++++++++++++++++++++++----------------
 ui/qt/widgets/byte_view_text.h   | 10 +++++
 4 files changed, 70 insertions(+), 36 deletions(-)