Wireshark-commits: [Wireshark-commits] master b8a330d: Qt: Update ByteView recent settings on all t
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 3 Jul 2020 06:12:09 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=b8a330d2d5e8f903b9d7da8ffa79efb4e15b526f
Submitter: "Stig Bjørlykke <stig@xxxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

b8a330d by Stig Bjørlykke (stig@xxxxxxxxxxxxx):

    Qt: Update ByteView recent settings on all tabs
    
    The ByteView recent settings are common for all tabs. Ensure all
    tabs are updated when display format or character encoding is changed.
    
    This fixes an issue where the row_width is wrong and the menu action
    checkmarks are out of sync after switching ByteView tab.
    
    Change-Id: Ied25ac41467143f37327ccadcb821262eb86ef0a
    Reviewed-on: https://code.wireshark.org/review/37655
    Petri-Dish: Stig Bjørlykke <stig@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Stig Bjørlykke <stig@xxxxxxxxxxxxx>
    

Actions performed:

    from  0c5b81c   DVB-RCS2: Added TIM, TMST, TDT and TBTP2 dissection
     add  b8a330d   Qt: Update ByteView recent settings on all tabs


Summary of changes:
 ui/qt/byte_view_tab.cpp          |  2 +
 ui/qt/byte_view_tab.h            |  1 +
 ui/qt/widgets/byte_view_text.cpp | 93 ++++++++++++++++++++++++----------------
 ui/qt/widgets/byte_view_text.h   | 10 +++++
 4 files changed, 70 insertions(+), 36 deletions(-)