Wireshark-commits: [Wireshark-commits] master-3.2 df35b80: Packetlogger: check for more packet type
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 2 Jul 2020 21:29:52 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=df35b8092079566d2abd18bc5e7995f8f41d5429
Submitter: "Guy Harris <gharris@xxxxxxxxx>"
Changed: branch: master-3.2
Repository: wireshark

Commits:

df35b80 by Guy Harris (gharris@xxxxxxxxx):

    Packetlogger: check for more packet types in the libwiretap heuristics.
    
    As we're now checking the first *few* packets of the file, we must allow
    *all* Packetlogger packet types when checking whether the purported
    packet type is valid.
    
    Put a note in the Packetlogger dissector so that, if anybody adds a new
    packet type, they know that they have to add it to the reader code as
    well.
    
    Bug: 16670
    Change-Id: Id83493f678182fd3e1b5537f4dfa295fe26dfcb1
    Reviewed-on: https://code.wireshark.org/review/37675
    Petri-Dish: Guy Harris <gharris@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Guy Harris <gharris@xxxxxxxxx>
    (cherry picked from commit 514f849bbea473c500df7ea30358ba2bc03eae31)
    Reviewed-on: https://code.wireshark.org/review/37677
    

Actions performed:

    from  e7b47af   Qt: Remove ellipsis from "Disable protocol" menu item
     add  df35b80   Packetlogger: check for more packet types in the libwiretap heuristics.


Summary of changes:
 epan/dissectors/packet-packetlogger.c | 10 ++++++++++
 wiretap/packetlogger.c                | 37 ++++++++++++++++++++++++++++++++++-
 2 files changed, 46 insertions(+), 1 deletion(-)