Wireshark-commits: [Wireshark-commits] master-3.2 11f4089: GVCP: Fix an infinite loop.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 30 Jun 2020 15:33:16 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=11f40896b696e4e8c7f8b2ad96028404a83a51a4
Submitter: "Gerald Combs <gerald@xxxxxxxxxxxxx>"
Changed: branch: master-3.2
Repository: wireshark

Commits:

11f4089 by Gerald Combs (gerald@xxxxxxxxxxxxx):

    GVCP: Fix an infinite loop.
    
    Remove an "if(tree)" test in order to ensure that our offset always
    advances.
    
    Bug: 16029
    Change-Id: I5bb38f2eccfbf3c44a06682a17aafcba9d8fa0c6
    Reviewed-on: https://code.wireshark.org/review/37611
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    (cherry picked from commit d70bd4489feed4035c3a35cd2e76cdf877b3f485)
    Reviewed-on: https://code.wireshark.org/review/37618
    

Actions performed:

    from  8f97d25   Qt: Accept changes in Decode As when combo box has focus
     add  11f4089   GVCP: Fix an infinite loop.


Summary of changes:
 epan/dissectors/packet-gvcp.c | 111 ++++++++++++++++++++----------------------
 1 file changed, 54 insertions(+), 57 deletions(-)