Wireshark-commits: [Wireshark-commits] master 570a0cb: Set member variables in initialiser list (ra
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 30 Jun 2020 12:11:28 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=570a0cb30134de8996067981841fb8899fbdecc4
Submitter: "Martin Mathieson <martin.r.mathieson@xxxxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

570a0cb by Martin Mathieson (martin.mathieson@xxxxxxxxxxxx):

    Set member variables in initialiser list (rather than in CTOR bodies).
    
    Also simplify some boolean logic in packet-dcerpc.c.
    All reported by cppcheck.
    
    Change-Id: I2075f2ec10dc777ad7635da4ef056d17fc5b0be0
    Reviewed-on: https://code.wireshark.org/review/37609
    Petri-Dish: Martin Mathieson <martin.r.mathieson@xxxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Reviewed-by: Martin Mathieson <martin.r.mathieson@xxxxxxxxxxxxxx>
    

Actions performed:

    from  d70bd44   GVCP: Fix an infinite loop.
     add  570a0cb   Set member variables in initialiser list (rather than in CTOR bodies).


Summary of changes:
 epan/dissectors/packet-dcerpc.c  |  2 +-
 ui/qt/capture_file.cpp           | 10 +++++-----
 ui/qt/iax2_analysis_dialog.cpp   | 12 ++++++------
 ui/qt/interface_toolbar_reader.h | 11 ++++++-----
 ui/qt/models/pref_models.cpp     |  2 +-
 5 files changed, 19 insertions(+), 18 deletions(-)