Wireshark-commits: [Wireshark-commits] master 8557c94: FTDI MPSSE: Dissect Bad Command response pay
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 27 Jun 2020 19:29:56 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=8557c94f87e3dc8661efaf10348545513a4b49b9
Submitter: "Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

8557c94 by Tomasz Moń (desowin@xxxxxxxxx):

    FTDI MPSSE: Dissect Bad Command response payload
    
    Undocumented data shitfing commands that operate in bitmode, MSB first,
    and have both Write TMS and Read TDO bits set, do not seem to consume
    the data payload. Do not dissect the data byte for these commands.
    
    Treat MCU Host mode commands as Bad Command when in MPSSE mode. MCU Host
    mode commands are recognized only in MCU Host mode. Add preliminary
    support for MCU Host mode dissection.
    
    Ping-Bug: 11743
    Change-Id: I3046aab92f69e2e141cb5a23c68e844b24b6c2ca
    Reviewed-on: https://code.wireshark.org/review/37566
    Petri-Dish: Tomasz Moń <desowin@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    

Actions performed:

    from  d933a98   A-bis/RSL: fix wrong parent tree in dissect_rsl_ie_cause()
     add  8557c94   FTDI MPSSE: Dissect Bad Command response payload


Summary of changes:
 epan/dissectors/packet-ftdi-ft.c    |  3 +-
 epan/dissectors/packet-ftdi-ft.h    |  1 +
 epan/dissectors/packet-ftdi-mpsse.c | 67 +++++++++++++++++++++++++++++++++----
 3 files changed, 64 insertions(+), 7 deletions(-)