Wireshark-commits: [Wireshark-commits] master f97e20a: RTPS: don't use incompletely filled in GUIDs
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 21 Jun 2020 19:33:30 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=f97e20a011144a56bf72dd92c49167d17713a909
Submitter: "Guy Harris <gharris@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

f97e20a by Guy Harris (gharris@xxxxxxxxx):

    RTPS: don't use incompletely filled in GUIDs.
    
    Add to the GUID type a bitmask that indicates which fields have been
    filled in; start it out as 0, and then set bits in it as fields get
    filled in.
    
    Do not add a type mapping object to the hash table unless the GUID is
    completely filled in, and don't look for a type mapping object in the
    hash table with a GUID that hasn't been completely filled in as a key.
    
    Bug: 16642
    Change-Id: I31db92238adcb2ec2d70b2650e41b14d99001908
    Reviewed-on: https://code.wireshark.org/review/37537
    Petri-Dish: Guy Harris <gharris@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Guy Harris <gharris@xxxxxxxxx>
    

Actions performed:

    from  4f1276b   WSDG: Update the Code Requirements section.
     add  f97e20a   RTPS: don't use incompletely filled in GUIDs.


Summary of changes:
 epan/dissectors/packet-rtps.c | 37 +++++++++++++++++++++++++++++++++++--
 1 file changed, 35 insertions(+), 2 deletions(-)