Wireshark-commits: [Wireshark-commits] master-3.2 ec0e70a: QUIC: fix Malformed Packet exception wit
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 17 Jun 2020 05:32:00 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=ec0e70a926aaf8b4c41f654e8f0ea9f3553b12c5
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master-3.2
Repository: wireshark

Commits:

ec0e70a by Peter Wu (peter@xxxxxxxxxxxxx):

    QUIC: fix Malformed Packet exception with small transport parameters
    
    Since draft 27 the minimum transport parameter size can be smaller than
    4 due to variable-length encoding. With ngtcp2-29-dsb.pcapng, the
    active_connection_id_limit at the end covers only three bytes for
    example. Even though the correct length is normally set later, the early
    attempt to read four bytes resulted in an Malformed Packet exception.
    
    Change-Id: I9ec6ec6c66ce7a993f2fcfdc987e35966dc809ac
    Ping-Bug: 13881
    Reviewed-on: https://code.wireshark.org/review/37483
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    (cherry picked from commit e3d44136f0f0026c5e893fa249f458073f3b7328)
    Reviewed-on: https://code.wireshark.org/review/37485
    Petri-Dish: Anders Broman <a.broman58@xxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  89878b3   proto: clean up comments.
     add  ec0e70a   QUIC: fix Malformed Packet exception with small transport parameters


Summary of changes:
 epan/dissectors/packet-tls-utils.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)