Wireshark · Wireshark-commits: [Wireshark-commits] master 18ffd52: RTP: Make Decode As handling consistent across subdissectors

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=18ffd52e8edb219717e7b530b3fe73451f1f1600
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

18ffd52 by John Thacker (johnthacker@xxxxxxxxx):

    RTP: Make Decode As handling consistent across subdissectors
    
    RTP has two dissector tables, one directly associated with payload types, and
    one which is associated with strings that appear in SDP commands. This makes
    all dissectors that are registered as a dynamic payload type that can be
    configured by SDP appear as a Decode As option for the RTP PT table.
    
    Some protocols were registered in the table for configuration by SDP but
    had no way to register with the rtp.pt table. These include EVRC, H.223,
    and v150fw.
    
    Other protocols had a long standing preference to set a dynamic payload type,
    but they still did not appear in the Decode As menu unless that preference
    was changed from the default, largely because of the way that the preference
    was not actually registered with the rtp.pt table unless it had a value in
    the dynamic payload type range. These include EVS, H.263P, H.264, H.265,
    ISMACryp, IuUP, LAPD, MP4V-ES, RTP-MIDI, and VP8.
    
    RFC 3551 says that not just the dynamic payload types, but also the unassigned
    and even the statically assigned payload types MAY be dynamically reassigned as
    necessary, so this patch also allows these preferences to be set for payload
    types less than 96. The only payload type not allowed is 0 (which RFCs 3551 and
    7007 say must be μ-law PCM), which is handy anyone for backwards compatibility
    with preferences that used to be uints (where 0 meant disabled.)
    
    All protcols which formerly used a uint preference are all converted to a
    range preference, and the text is changed to be similar for each. This works
    in a backwards compatible fashion, and any defaults are maintained.
    
    The patch also adds some of the dissector variants as PINOs so that they will
    show up with distinct names in the Decode As menus, and changes some of the
    protocol short names so that the entry in Decode As is clearer and matches
    what is used for other similar protocols.
    
    Change-Id: I68627b5c3e495d9fc813d88208f3b62e47e0c4de
    Reviewed-on: https://code.wireshark.org/review/37396
    Petri-Dish: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  eddfa0f   dissectors: hartip: Fix command 77 decoding
     add  18ffd52   RTP: Make Decode As handling consistent across subdissectors


Summary of changes:
 epan/dissectors/packet-amr.c        | 21 ++++++------
 epan/dissectors/packet-evrc.c       | 38 ++++++++++++++++++---
 epan/dissectors/packet-evs.c        | 28 ++++++++--------
 epan/dissectors/packet-h223.c       |  1 +
 epan/dissectors/packet-h263p.c      | 31 ++++++++---------
 epan/dissectors/packet-h264.c       | 25 +++++---------
 epan/dissectors/packet-h265.c       | 26 ++++-----------
 epan/dissectors/packet-ismacryp.c   | 37 ++++++++++++---------
 epan/dissectors/packet-iuup.c       | 24 +++++++-------
 epan/dissectors/packet-lapd.c       | 24 +++++++-------
 epan/dissectors/packet-mp4ves.c     | 27 ++++++++-------
 epan/dissectors/packet-mtp2.c       | 16 ++++-----
 epan/dissectors/packet-rfc2190.c    |  2 +-
 epan/dissectors/packet-rtp-events.c | 66 +++++++++++++++++++------------------
 epan/dissectors/packet-rtp-midi.c   | 22 ++++++++-----
 epan/dissectors/packet-rtp.c        | 30 ++++++++++-------
 epan/dissectors/packet-v150fw.c     |  2 +-
 epan/dissectors/packet-vp8.c        | 19 +++--------
 18 files changed, 222 insertions(+), 217 deletions(-)