Wireshark-commits: [Wireshark-commits] master 4e6f47f: Qt: Make our exported and saved line endings
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 30 May 2020 06:46:14 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=4e6f47fa622e773c3b432a23627a130387f2ffe8
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

4e6f47f by Gerald Combs (gerald@xxxxxxxxxxxxx):

    Qt: Make our exported and saved line endings consistent.
    
    Make sure we set QIODevice::Text on our QTextStreams when saving and
    exporting text so that we get native line endings on Windows.
    
    Change-Id: I4602157d2d170eb9a2c79032254ea5be236c7589
    Reviewed-on: https://code.wireshark.org/review/37336
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  76d92ba   Qt: Updates for 5.15.
     add  4e6f47f   Qt: Make our exported and saved line endings consistent.


Summary of changes:
 ui/qt/follow_stream_dialog.cpp     |  2 --
 ui/qt/io_graph_dialog.cpp          |  2 +-
 ui/qt/show_packet_bytes_dialog.cpp | 18 +++++++++++++++++-
 3 files changed, 18 insertions(+), 4 deletions(-)