Wireshark-commits: [Wireshark-commits] master fc35d51: Fix compilation without kerberos.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 27 May 2020 19:12:14 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=fc35d510898c8e33ea5b2c91d2320942111ec7f7
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

fc35d51 by Dario Lombardo (lomato@xxxxxxxxx):

    Fix compilation without kerberos.
    
    Error:
    ./asn1/kerberos/packet-kerberos-template.c:109:2: error: unknown type name ‘enc_key_t’
    ./asn1/kerberos/kerberos.cnf: In function ‘dissect_kerberos_EncryptionKey’:
    ./asn1/kerberos/kerberos.cnf:386:7: error: unused variable ‘start_offset’ [-Werror=unused-variable]
    ./asn1/kerberos/kerberos.cnf: In function ‘dissect_kerberos_T_authenticator_subkey’:
    ./asn1/kerberos/kerberos.cnf:406:42: error: ‘save_Authenticator_subkey’ undeclared (first use in this function); did you mean ‘hf_kerberos_authenticator_subkey’?
    ./asn1/kerberos/kerberos.cnf:406:42: note: each undeclared identifier is reported only once for each function it appears in
    ./asn1/kerberos/kerberos.cnf: In function ‘dissect_kerberos_T_encTicketPart_key’:
    ./asn1/kerberos/kerberos.cnf:445:42: error: ‘save_EncTicketPart_key’ undeclared (first use in this function); did you mean ‘hf_kerberos_encTicketPart_key’?
    ./asn1/kerberos/kerberos.cnf: In function ‘dissect_kerberos_T_encKDCRepPart_key’:
    ./asn1/kerberos/kerberos.cnf:435:42: error: ‘save_EncKDCRepPart_key’ undeclared (first use in this function); did you mean ‘hf_kerberos_encKDCRepPart_key’?
    ./asn1/kerberos/kerberos.cnf: In function ‘dissect_kerberos_T_encAPRepPart_subkey’:
    ./asn1/kerberos/kerberos.cnf:416:42: error: ‘save_EncAPRepPart_subkey’ undeclared (first use in this function); did you mean ‘hf_kerberos_encAPRepPart_subkey’?
    ./asn1/kerberos/kerberos.cnf: In function ‘dissect_kerberos_T_krbCredInfo_key’:
    ./asn1/kerberos/kerberos.cnf:455:42: error: ‘save_KrbCredInfo_key’ undeclared (first use in this function); did you mean ‘hf_kerberos_krbCredInfo_key’?
    cc1: all warnings being treated as errors
    
    Change-Id: Ib9e38c3d745dd8a12ac8e4691918770a8b876727
    Reviewed-on: https://code.wireshark.org/review/37313
    Petri-Dish: Dario Lombardo <lomato@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  64d99d6   NAS 5GS: do not stop dissection if the messages are integrity protected only
     add  fc35d51   Fix compilation without kerberos.


Summary of changes:
 epan/dissectors/asn1/kerberos/kerberos.cnf         |  26 +-
 .../asn1/kerberos/packet-kerberos-template.c       | 241 ++++++++-
 epan/dissectors/packet-kerberos.c                  | 540 +++++++++++----------
 3 files changed, 530 insertions(+), 277 deletions(-)