Wireshark-commits: [Wireshark-commits] master fa60a8c: packet-kerberos: provide details about missi
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 26 May 2020 12:10:42 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=fa60a8c5f5cc2b3426368308b7e60d62d1c8ac68
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

fa60a8c by Stefan Metzmacher (metze@xxxxxxxxx):

    packet-kerberos: provide details about missing keys
    
    It's useful to see which decryption keys are missing!
    The "kerberos.missing_keytype" filter can be used to find all of them.
    
    It's also useful to see which key_map was is in used
    and how many decryption attempts were tried.
    
    This should also allow future optimizations in
    order to avoid decryption attempts based on the usage
    and more detailed key maps.
    
    Change-Id: Ie0302454e29a65aa00ddac79839aac8ec63fa290
    Signed-off-by: Stefan Metzmacher <metze@xxxxxxxxx>
    Reviewed-on: https://code.wireshark.org/review/37297
    Petri-Dish: Anders Broman <a.broman58@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  738e73a   packet-kerberos: add support for decrypting KRB5 FAST messages
     add  fa60a8c   packet-kerberos: provide details about missing keys


Summary of changes:
 .../asn1/kerberos/packet-kerberos-template.c       | 186 ++++++++++++++++++-
 epan/dissectors/packet-kerberos.c                  | 198 +++++++++++++++++++--
 2 files changed, 366 insertions(+), 18 deletions(-)