Wireshark · Wireshark-commits: [Wireshark-commits] master 62f25df: dot11decrypt: Use hash table to store SA entries

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=62f25dfa64d6c2ff5e374bbc568193b5ea066771
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

62f25df by Mikael Kanstrup (mikael.kanstrup@xxxxxxxx):

    dot11decrypt: Use hash table to store SA entries
    
    Simplify the SA storage by replacing the static array with a
    hash table. This way there's no need to keep track of whether
    an entry is used or not and no need to traverse the whole
    array for the non-matching case. This change should benefit
    performance but was mainly done to prepare for coming changes
    where code adding and searching for SA entries is modified. With
    this change in place those changes become cleaner.
    
    Change-Id: Ide572c5e4e7e872f1654d8d8f288cd6451f04435
    Reviewed-on: https://code.wireshark.org/review/37307
    Petri-Dish: Anders Broman <a.broman58@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  499a49f   dot11decrypt: Remove DEBUG_TRACE_START/END macros
     add  62f25df   dot11decrypt: Use hash table to store SA entries


Summary of changes:
 epan/crypt/dot11decrypt.c          | 189 ++++++++++++-------------------------
 epan/crypt/dot11decrypt_system.h   |  17 +---
 epan/dissectors/packet-ieee80211.c |   2 +-
 3 files changed, 62 insertions(+), 146 deletions(-)