Wireshark-commits: [Wireshark-commits] master 20bfb9f: packet-kerberos: use a fixed keyvalue buffer
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 25 May 2020 06:34:10 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=20bfb9ffb90cac37892630e1c24743c8b6800471
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

20bfb9f by Stefan Metzmacher (metze@xxxxxxxxx):

    packet-kerberos: use a fixed keyvalue buffer for enc_key_t
    
    With AES-256 we need 32 bytes, there's no need to use allocated memory.
    
    Change-Id: Ibbb99523c00f167d0b4dce95f038707855964bde
    Signed-off-by: Stefan Metzmacher <metze@xxxxxxxxx>
    Reviewed-on: https://code.wireshark.org/review/37282
    Petri-Dish: Anders Broman <a.broman58@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  4d801ab   packer-kerberos: maintain enc_key_t->id as a unique number
     add  20bfb9f   packet-kerberos: use a fixed keyvalue buffer for enc_key_t


Summary of changes:
 .../asn1/kerberos/packet-kerberos-template.c          | 13 +++++++++----
 .../asn1/kerberos/packet-kerberos-template.h          |  5 +++--
 epan/dissectors/packet-kerberos.c                     | 19 ++++++++++++-------
 epan/dissectors/packet-kerberos.h                     |  7 ++++---
 4 files changed, 28 insertions(+), 16 deletions(-)