Wireshark-commits: [Wireshark-commits] master d34a806: UNISTIM: Refactor display address/control/ta
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 24 May 2020 13:06:49 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=d34a806e86bceb7036f9bc7b77eeeee4b75592a4
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

d34a806 by David Perry (boolean263@xxxxxxxxxxxxxx):

    UNISTIM: Refactor display address/control/tag handling
    
    The 8 combinations of the display address, control, and tag were being
    handled as 8 separate cases in `dissect_display_switch()`. This resulted
    in duplicated, inconsistent code. Some paths resulted in bug #15219
    while others did not have this problem.
    
    I believe I have been able to combine them all into a single case branch
    which handles each aspect correctly. I am not a UNISTIM expert and
    welcome more knowledgeable reviewers.
    
    Bug: 15219
    Change-Id: Ie3eee8e19c10daab27c1df599ce0d03b52f69205
    Reviewed-on: https://code.wireshark.org/review/37190
    Petri-Dish: Anders Broman <a.broman58@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  41c80cd   Update doxygen config to 1.8.17
     add  d34a806   UNISTIM: Refactor display address/control/tag handling


Summary of changes:
 plugins/epan/unistim/packet-unistim.c | 312 ++++++++--------------------------
 1 file changed, 68 insertions(+), 244 deletions(-)