Wireshark · Wireshark-commits: [Wireshark-commits] master-3.0 7def211: GSM/SMS: clarify 'no error' values of TP-Status IE

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=7def211934477bd778c7cbd9b0e869ddb46847bd
Submitter: "Guy Harris <gharris@xxxxxxxxx>"
Changed: branch: master-3.0
Repository: wireshark

Commits:

7def211 by Vadim Yanitskiy (axilirator@xxxxxxxxx):

    GSM/SMS: clarify 'no error' values of TP-Status IE
    
    In case of successfull delivery, TP-Status IE looks as follows:
    
      TP-Status
          0... .... = Definition of bits 0-6: as follows
          .00. .... = Error: Short message transaction completed (0)
          ...0 0000 = Reason: Short message received by the SME (0)
    
    in particular, "Error: Short message transaction completed" looks
    confusing. Let's make it a bit cleaner:
    
      TP-Status
          0... .... = Definition of bits 0-6: as follows
          .00. .... = Error: No error, short message transaction completed (0)
          ...0 0000 = Reason: Short message received by the SME (0)
    
    Change-Id: I95830877c1ff2f45e3c68a40febcf357abda597d
    Reviewed-on: https://code.wireshark.org/review/36829
    Reviewed-by: Pascal Quantin <pascal@xxxxxxxxxxxxx>
    (cherry picked from commit 514706b1f87c0a1a45eff4d91d31faec6a9d9323)
    Reviewed-on: https://code.wireshark.org/review/37229
    Reviewed-by: Guy Harris <gharris@xxxxxxxxx>
    

Actions performed:

    from  9d86aa3   GSM/SMS: decouple error and reason fields in TP-Status IE
     add  7def211   GSM/SMS: clarify 'no error' values of TP-Status IE


Summary of changes:
 epan/dissectors/packet-gsm_sms.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)