Wireshark-commits: [Wireshark-commits] master da8c28d: CIP Motion: Connection Configuration Data
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 13 May 2020 11:01:41 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=da8c28dc67ac3d319fa8f97a6f74682043eaf0f2
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

da8c28d by Dylan Ulis (daulis0@xxxxxxxxx):

    CIP Motion: Connection Configuration Data
    
    1. Dissect the Motion Configuration Block from the Forward Open
    2. Add Motion Attributes related to #1
    3. Save the first/last segment for certain segment types in an EPATH.
    Behavior changes based on the values in first segments for a given type,
    vs later segments.
    
    Change-Id: Id0552a585d158041c13adfa50f4bb164cada79b7
    Reviewed-on: https://code.wireshark.org/review/37168
    Petri-Dish: Anders Broman <a.broman58@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  256cc1a   RTPS: updated submessage parsing to match protocol spec
     add  da8c28d   CIP Motion: Connection Configuration Data


Summary of changes:
 epan/dissectors/packet-cip.c       | 132 +++++++++++++++++++++++++++----------
 epan/dissectors/packet-cip.h       |  13 ++++
 epan/dissectors/packet-cipmotion.c |  85 +++++++++++++++++++++++-
 epan/dissectors/packet-cipmotion.h |   4 +-
 epan/dissectors/packet-cipsafety.c |   2 +-
 5 files changed, 199 insertions(+), 37 deletions(-)