Wireshark · Wireshark-commits: [Wireshark-commits] master 5e4379f: IDL: make code generation reproducible

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=5e4379f5b5fbf40151d58e6aab28b072e39fde17
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

5e4379f by Jaap Keuter (jaap.keuter@xxxxxxxxx):

    IDL: make code generation reproducible
    
    The current state of generated code from the IDL specification is not
    reproducible with the current omniidl backend. This change brings the
    backend in line with the currently committed generated source code.
    
    The exception to this is that the exceptions (no pun intended) were
    collected in a dictionary of unspecified ordering, therefore inherently
    non-reproducible. These thus differ from the previously committed source
    code (packet-parlay.c), but do contain the same lines.
    
    Also this rolls back commit 443df9389661901e8347f33864e2cd7539dbda9f
    because the committed generated source files were not created with the
    backend with this change, nor do they fail to build, as claimed in that
    commit.
    
    Special thanks to Luke Mewburn for working on the dictionary problem.
    
    Change-Id: I7707746d263c7556eb06883c877f70f0e9b357c5
    Reviewed-on: https://code.wireshark.org/review/37153
    Reviewed-by: Jaap Keuter <jaap.keuter@xxxxxxxxx>
    Petri-Dish: Jaap Keuter <jaap.keuter@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  ddc5a49   EAP: AT_NOTIFICATION Dissection
     add  5e4379f   IDL: make code generation reproducible


Summary of changes:
 epan/dissectors/packet-parlay.c | 2034 +++++++++++++++++++--------------------
 tools/wireshark_gen.py          |   19 +-
 2 files changed, 1027 insertions(+), 1026 deletions(-)