Wireshark-commits: [Wireshark-commits] master-3.0 51260d3: Infiniband: skip past the undissected ve
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 05 May 2020 05:20:14 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=51260d32dc1011f2cd7693eca4a3f5b6a3604e25
Submitter: "Guy Harris <gharris@xxxxxxxxx>"
Changed: branch: master-3.0
Repository: wireshark

Commits:

51260d3 by Guy Harris (guy@xxxxxxxxxxxx):

    Infiniband: skip past the undissected vendor header.
    
    In parse_VENDOR() get the length of the raw data (presumed to be
    vendor-specific data) by using proto_tree_add_item_ret_length(), and add
    that to the offset.
    
    Should addresses PVS-Studio complaint
    
    /opt/SourceCode/wireshark/epan/dissectors/packet-infiniband.c	2782	warn
    V1048 The '* offset' variable was assigned the same value.
    
    Change-Id: Icac567e3ef2ad0484aaa111e5bc8a5cd83d9d8a5
    Reviewed-on: https://code.wireshark.org/review/37143
    Petri-Dish: Guy Harris <gharris@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Guy Harris <gharris@xxxxxxxxx>
    (cherry picked from commit c5215707d47082c1de2459dc9d1e4be7ad2d974e)
    Reviewed-on: https://code.wireshark.org/review/37145
    

Actions performed:

    from  c38d416   pcapng (dissector): don't assume the endianness doesn't change.
     add  51260d3   Infiniband: skip past the undissected vendor header.


Summary of changes:
 epan/dissectors/packet-infiniband.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)