Wireshark-commits: [Wireshark-commits] master-3.2 16369e0: pcapng: pull the interface ID handling i
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 04 May 2020 19:02:02 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=16369e0758dc19f4a6b246f848d18c210cd761cc
Submitter: "Guy Harris <gharris@xxxxxxxxx>"
Changed: branch: master-3.2
Repository: wireshark

Commits:

16369e0 by Guy Harris (guy@xxxxxxxxxxxx):

    pcapng: pull the interface ID handling into a single routine.
    
    Have a routine that takes an interface ID as an argument and:
    
    	if it's within range, fetches the interface description and
    	returns a pointer to it;
    
    	if it's not within range, adds an expert info and returns NULL;
    
    and have the code to dissect blocks with interface IDs just call it.
    
    Change-Id: I705fe94a9a5fb5a27650465f3c55e0dc1b6fbd23
    Reviewed-on: https://code.wireshark.org/review/37090
    Petri-Dish: Guy Harris <gharris@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Guy Harris <gharris@xxxxxxxxx>
    (cherry picked from commit f3ddcb96a369472cde3c83f26ff747d5772b8e3a)
    Reviewed-on: https://code.wireshark.org/review/37109
    

Actions performed:

    from  5473477   pcapng: fix more interface ID checks.
     add  16369e0   pcapng: pull the interface ID handling into a single routine.


Summary of changes:
 epan/dissectors/file-pcapng.c | 77 ++++++++++++++++++++++++-------------------
 1 file changed, 44 insertions(+), 33 deletions(-)