Wireshark-commits: [Wireshark-commits] master-3.0 e2d48d5: pcapng: fix more interface ID checks.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 04 May 2020 19:01:18 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=e2d48d5209ceeaa6cff6e4bfc8092c7a476468a0
Submitter: "Guy Harris <gharris@xxxxxxxxx>"
Changed: branch: master-3.0
Repository: wireshark

Commits:

e2d48d5 by Guy Harris (guy@xxxxxxxxxxxx):

    pcapng: fix more interface ID checks.
    
    Fix the check for the Interface Statistics Block as well.
    
    Make the check for the Simple Packet BLock similar to the other checks -
    at the beginning, set interface_id to 0 and then check interface_id
    against the size of the array.
    
    Change-Id: Ib05255fe13eca6292447f365b62ff3094805bd4a
    Reviewed-on: https://code.wireshark.org/review/37071
    Petri-Dish: Guy Harris <gharris@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Guy Harris <gharris@xxxxxxxxx>
    (cherry picked from commit 60622e63fd561830e1de24e28ae4e5f7952ed130)
    Reviewed-on: https://code.wireshark.org/review/37107
    

Actions performed:

    from  9a2f2d7   pcpang: fix test for missing IDB.
     add  e2d48d5   pcapng: fix more interface ID checks.


Summary of changes:
 epan/dissectors/file-pcapng.c | 12 +++++-------
 1 file changed, 5 insertions(+), 7 deletions(-)