Wireshark-commits: [Wireshark-commits] master-2.6 6cdc198: pcpang: fix test for missing IDB.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 04 May 2020 19:00:32 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=6cdc1981a630dc60fa2ba54ffb2cefa699aeeb0e
Submitter: "Guy Harris <gharris@xxxxxxxxx>"
Changed: branch: master-2.6
Repository: wireshark

Commits:

6cdc198 by Guy Harris (guy@xxxxxxxxxxxx):

    pcpang: fix test for missing IDB.
    
    *Any* packet block can have an invalid interface ID; that's not just an
    error in the first packet block.
    
    For Enhanced Packet Blocks and Packet Blocks, you can have an invalid
    interface ID even if you've already seen one or more Interface
    Description Blocks; you have to check whether the interface ID is >= the
    number of IDBs we've seen.
    
    Change-Id: I33268d224ef3ad928ad9c000027fb6783806b978
    Reviewed-on: https://code.wireshark.org/review/37070
    Petri-Dish: Guy Harris <gharris@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Guy Harris <gharris@xxxxxxxxx>
    (cherry picked from commit 29340f1b33db6f3abb4bdd80a949430d20020d7d)
    Reviewed-on: https://code.wireshark.org/review/37105
    

Actions performed:

    from  9eb6498   pcapng: expert info when packet or ISB appear without interfaces
     add  6cdc198   pcpang: fix test for missing IDB.


Summary of changes:
 epan/dissectors/file-pcapng.c | 16 +++++++---------
 1 file changed, 7 insertions(+), 9 deletions(-)