Wireshark-commits: [Wireshark-commits] master 1a9c536: pcapng: expert info when packet or ISB appea
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 03 May 2020 13:12:13 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=1a9c5364d18b32c5fef72c0bcb3ea2095e60d8b0
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

1a9c536 by David Perry (boolean263@xxxxxxxxxxxxxx):

    pcapng: expert info when packet or ISB appear without interfaces
    
    A valid pcapng file must have an IDB before any EPB/SPB/PB/ISB. So check
    our interface count when we parse the first such block of a section, and
    add expert info if there are no interfaces.
    
    Discovered during work on Bug #16526.
    
    Ping-Bug: 16526
    Change-Id: I23ff452fd163a0e4472e0658a905f85ab85d5e9d
    Reviewed-on: https://code.wireshark.org/review/36986
    Reviewed-by: Jaap Keuter <jaap.keuter@xxxxxxxxx>
    Petri-Dish: Jaap Keuter <jaap.keuter@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  cac7dd3   GTP: add support to decode TPDU as ethernet
     add  1a9c536   pcapng: expert info when packet or ISB appear without interfaces


Summary of changes:
 epan/dissectors/file-pcapng.c | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)