Wireshark-commits: [Wireshark-commits] master-2.6 4c98bdd: More issues spotted by PVS-Studio in bug
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 03 May 2020 06:37:18 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=4c98bddc07a372c26cb60d4991fc26a91c07a2ed
Submitter: "Guy Harris <gharris@xxxxxxxxx>"
Changed: branch: master-2.6
Repository: wireshark

Commits:

4c98bdd by Martin Mathieson (martin.mathieson@xxxxxxxxxxxx):

    More issues spotted by PVS-Studio in bug 16335.
    
    Only the change to packet-imap.c really represents a bug.
    
    Change-Id: Ie270f97f3d94c338ea3c84a712f8f4d43ffd36f4
    Reviewed-on: https://code.wireshark.org/review/36115
    Petri-Dish: Martin Mathieson <martin.r.mathieson@xxxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    (backported from commit 7e02165453f78dc2196d66d6167d8fdeebdf2cb3)
    Reviewed-on: https://code.wireshark.org/review/37054
    Petri-Dish: Guy Harris <gharris@xxxxxxxxx>
    Reviewed-by: Guy Harris <gharris@xxxxxxxxx>
    

Actions performed:

    from  3d5029c   Some issues spotted by PVS-Studio in bug 16335.  Many more remain
     add  4c98bdd   More issues spotted by PVS-Studio in bug 16335.


Summary of changes:
 epan/dissectors/packet-ber.c   | 15 ++++++---------
 epan/dissectors/packet-ftp.c   |  8 ++------
 epan/dissectors/packet-sdp.c   |  2 --
 epan/dissectors/packet-sip.c   |  1 -
 epan/dissectors/snort-config.c |  2 +-
 wiretap/catapult_dct2000.c     |  1 -
 6 files changed, 9 insertions(+), 20 deletions(-)