Wireshark-commits: [Wireshark-commits] master 3bb7d00: pcapng: have per-section interface tables ra
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 30 Apr 2020 18:11:02 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=3bb7d00d41e25f6832343ce54f3e554d392f2927
Submitter: "Guy Harris <gharris@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

3bb7d00 by Guy Harris (guy@xxxxxxxxxxxx):

    pcapng: have per-section interface tables rather than per-file.
    
    This moves us closer to fixing bug 16531; it addresses the second issue
    there, as the right snapslen is used for packets in the second section,
    so we no longer get errors reading the file.
    
    It still doesn't fix the *names* of the interfaces, and it doesn't - and
    *shouldn't* - show the interfaces with different interface numbers, as
    the numbers are per-section rather than global.
    
    Change-Id: Ia3aa3309b75a4bcd9f229048ddce6a981b9409b1
    Ping-Bug: 16531
    Reviewed-on: https://code.wireshark.org/review/36985
    Petri-Dish: Guy Harris <gharris@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Guy Harris <gharris@xxxxxxxxx>
    

Actions performed:

    from  adb8fee   Qt: Allow renaming personal profile
     add  3bb7d00   pcapng: have per-section interface tables rather than per-file.


Summary of changes:
 wiretap/pcapng.c | 55 ++++++++++++++++++++++++++++++++++---------------------
 1 file changed, 34 insertions(+), 21 deletions(-)