Wireshark · Wireshark-commits: [Wireshark-commits] master 07576e9: pcapng: clean up handling of current vs. new section.

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=07576e9f3be231e5b53b0bd35357941266823354
Submitter: "Guy Harris <gharris@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

07576e9 by Guy Harris (guy@xxxxxxxxxxxx):

    pcapng: clean up handling of current vs. new section.
    
    Have pcapng_read_block() take two pointers to a section_info_t as
    arguments - one for the current section, if any, and one to something to
    fill in, as information for the new section, if the block is an SHB.
    
    The first of them is null when we're trying to read the first block;
    that serves as an indication that "not an SHB" means "this file isn't a
    pcapng file" rather than "this pcapng file is bad".
    
    Change-Id: I1b0a8bfacde982b819e548847bcc9412d30788f3
    Reviewed-on: https://code.wireshark.org/review/36984
    Petri-Dish: Guy Harris <gharris@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Guy Harris <gharris@xxxxxxxxx>
    

Actions performed:

    from  ada193f   ieee80211: fix typo naqp => anqp
     add  07576e9   pcapng: clean up handling of current vs. new section.


Summary of changes:
 wiretap/pcapng.c | 126 ++++++++++++++++++++++++++++++-------------------------
 1 file changed, 70 insertions(+), 56 deletions(-)