Wireshark-commits: [Wireshark-commits] master 928bbf5: capinfos: fix absolute and relative time dis
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 29 Apr 2020 19:11:25 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=928bbf5984ee8b81e960c3d53c1d8d2e1bc2bdbf
Submitter: "Guy Harris <gharris@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

928bbf5 by Guy Harris (guy@xxxxxxxxxxxx):

    capinfos: fix absolute and relative time display.
    
    Make the buffers big enough to handle the largest possible time values
    you can get with a 64-bit time_t.
    
    Don't cast the seconds value to unsigned long; it's probably signed, and
    may not fit in an unsigned long (64-bit on an ILP32 or LLP64 platform),
    so cast it to gint64 and print using G_GINT64_MODIFIER followed by "d".
    
    Bug: 16519
    Change-Id: I3ab79dfa086d2c4dfb6b93eba8cef3bdce731731
    Reviewed-on: https://code.wireshark.org/review/36971
    Petri-Dish: Guy Harris <gharris@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Guy Harris <gharris@xxxxxxxxx>
    

Actions performed:

    from  0eb92d7   Document unit string and true false string helper functions
     add  928bbf5   capinfos: fix absolute and relative time display.


Summary of changes:
 capinfos.c | 91 ++++++++++++++++++++++++++++++++++++++++++++------------------
 1 file changed, 65 insertions(+), 26 deletions(-)