Wireshark · Wireshark-commits: [Wireshark-commits] master e4aeb1d: Clean up the encoding value definitions.

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=e4aeb1d2bb4a2f0559f6ee938de45b7f42d82fa3
Submitter: "Guy Harris <gharris@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

e4aeb1d by Guy Harris (guy@xxxxxxxxxxxx):

    Clean up the encoding value definitions.
    
    Group them by the data types for which they're used, starting with the
    byte-order definitions which (with the inclusion of ENC_NA) are used
    with all types.
    
    Put all the ones used for strings together, starting with the character
    encodings, with the Zigbee flag and the flags for "this is a string but
    we're going to interpret it as a byte array or time stamp".
    
    Make ENC_CHARENCODING_MASK equal to ENC_STR_MASK; no, there's no reason
    for ENC_STR_MASK to replace ENC_CHARENCODING_MASK - the opposite should
    happen, as ENC_CHARENCODING_MASK at least specifies what the bits set in
    it are used for, namely character encodings.  If all #defines for
    strings should have _STR_ in them, start with the character encoings.
    
    Change-Id: I072420f313086153b4ea4034911fc293453dea00
    Reviewed-on: https://code.wireshark.org/review/36962
    Petri-Dish: Guy Harris <gharris@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Guy Harris <gharris@xxxxxxxxx>
    

Actions performed:

    from  9eaf9a5   proto(.h): fix parameter (it is pi not it) like on proto.c
     add  e4aeb1d   Clean up the encoding value definitions.


Summary of changes:
 epan/proto.h  | 263 +++++++++++++++++++++++++++++++++-------------------------
 epan/tvbuff.c |   2 +-
 2 files changed, 151 insertions(+), 114 deletions(-)