Wireshark-commits: [Wireshark-commits] master 7fcac9c: Qt: Fix export of dissection
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 27 Apr 2020 16:00:11 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=7fcac9c955af94f0d046e985278ea41936a3b1a2
Submitter: "Gerald Combs <gerald@xxxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

7fcac9c by Roland Knall (rknall@xxxxxxxxx):

    Qt: Fix export of dissection
    
    Exporting dissected bytes did not consider the
    selection of packets on Windows, if multiple
    packets had been selected
    
    Bug: 16516
    Change-Id: I9d914fe1fed22f842d73caea397a3f37ffc0d523
    Reviewed-on: https://code.wireshark.org/review/36958
    Reviewed-by: Roland Knall <rknall@xxxxxxxxx>
    Petri-Dish: Roland Knall <rknall@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    

Actions performed:

    from  ca4cc6a   proto(.h): fix -Wdocumentation
     add  7fcac9c   Qt: Fix export of dissection


Summary of changes:
 ui/qt/export_dissection_dialog.cpp |  4 +++-
 ui/qt/export_dissection_dialog.h   |  2 ++
 ui/win32/file_dlg_win32.c          | 13 +++++++------
 ui/win32/file_dlg_win32.h          |  3 ++-
 4 files changed, 14 insertions(+), 8 deletions(-)