Wireshark-commits: [Wireshark-commits] master-3.2 3ba3dad: DIS: dissector fix for Articulated Part
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 26 Apr 2020 06:12:28 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=3ba3dadfb2e430d66d2a3f632053944319060b8c
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master-3.2
Repository: wireshark

Commits:

3ba3dad by Bert van Leeuwen (bert.vanleeuwen@xxxxxxxxx):

    DIS: dissector fix for Articulated Part VP records.
    
    The IEEE 1278.1-2012 spec for DIS (Distributed Interactive Simulation)
    specifies the format of Articulated Part VP record as:
    8bits  Record Type         enum
    8bits  Change Indicator    unsigned integer
    16bits ID                  unsigned integer
    32bits Parameter Type      enum
    32bits Parameter Value     floating point
    32bits Padding             unused
    
    (Section 6.2.94.2)
    
    The dissector was interpreting the last 64bits as one value, this patch
    fixes it to interpret it as 32bit float and 32bit padding.
    
    Change-Id: Id509715f02daeecf12e3094fc1ed63e81705852b
    Reviewed-on: https://code.wireshark.org/review/36922
    Petri-Dish: Anders Broman <a.broman58@xxxxxxxxx>
    Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Jaap Keuter <jaap.keuter@xxxxxxxxx>
    (cherry picked from commit 5a854b882fd90f97e20539568e8277f12a98c342)
    Reviewed-on: https://code.wireshark.org/review/36936
    Petri-Dish: Jaap Keuter <jaap.keuter@xxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  1409d1f   Docs+help: Remove "-m".
     add  3ba3dad   DIS: dissector fix for Articulated Part VP records.


Summary of changes:
 epan/dissectors/packet-dis.c | 15 ++++++++++++---
 1 file changed, 12 insertions(+), 3 deletions(-)