Wireshark-commits: [Wireshark-commits] master d2824f4: Fix display of header length and timestamps
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 25 Apr 2020 14:52:28 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=d2824f4820f662ccddea08455ea903de69a87072
Submitter: "Jaap Keuter <jaap.keuter@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

d2824f4 by Dennis Bush (bush@xxxxxxxx):

    Fix display of header length and timestamps in UFTP4
    
    The headers for UFTP version 4 contain a header length field which gives
    the length of the header in 4 byte words.  Currently, only the raw value
    is displayed, not the actual byte count (for example 4 instead of 16).
    
    Several headers contain a timestamp field composed of 4 byte seconds and
    4 byte microseconds since the UNIX epoch.  These are currently being
    interpreted incorrectly as nanoseconds instead of microseconds.
    
    The FILEINFO header contains a file timestamp field composed of 4 bytes
    seconds since the epoch that is currently displayed as a raw value
    instead of as a timestamp.
    
    Change-Id: I936eb5317ca6802a094d8c1e01ae8ae78bb5cb7c
    Reviewed-on: https://code.wireshark.org/review/36910
    Petri-Dish: Jaap Keuter <jaap.keuter@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Jaap Keuter <jaap.keuter@xxxxxxxxx>
    

Actions performed:

    from  10be281   Docs: Switch from [float] to [discrete].
     add  d2824f4   Fix display of header length and timestamps in UFTP4


Summary of changes:
 epan/dissectors/packet-uftp4.c | 64 +++++++++++++++++++++---------------------
 1 file changed, 32 insertions(+), 32 deletions(-)