Wireshark-commits: [Wireshark-commits] master c9295f1: isakmp: clean up EMERGENCY_CALL_NUMBER disse
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 25 Apr 2020 00:26:03 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=c9295f161c4a6275faa98a77a3a81380e01b34d8
Submitter: "Guy Harris <gharris@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

c9295f1 by Guy Harris (guy@xxxxxxxxxxxx):

    isakmp: clean up EMERGENCY_CALL_NUMBER dissection.
    
    Don't use hf_text_only.  For the protocol tree items that are just
    subtrees, use proto_tree_add_subtree(); for the emergency call numbers,
    give them real FT_STRING fields, using tvb_bcd_dig_to_wmem_packet_str().
    
    Change-Id: I721271e26502abce8d8ce2375fc0916c0de586e6
    Reviewed-on: https://code.wireshark.org/review/36928
    Petri-Dish: Guy Harris <gharris@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Guy Harris <gharris@xxxxxxxxx>
    

Actions performed:

    from  ba50c5a   Check the validator in ExtArgText::isValid().
     add  c9295f1   isakmp: clean up EMERGENCY_CALL_NUMBER dissection.


Summary of changes:
 epan/dissectors/packet-isakmp.c | 40 +++++++++-------------------------------
 1 file changed, 9 insertions(+), 31 deletions(-)