Wireshark · Wireshark-commits: [Wireshark-commits] master b1668e7: NFS: fix dissecting of READ_PLUS contents

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=b1668e77e48abbce9d82941ab0dde848b13791fa
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

b1668e7 by Jorge Mora (jmora1300@xxxxxxxxx):

    NFS: fix dissecting of READ_PLUS contents
    
    Fixing two issues:
    1. Dissecting each item in the content list is off by 4 bytes,
       so the content type, the offset and the length are all
       incorrect.
    2. When the content item is a HOLE the length should be 8 bytes
       not 4.
    
    Also, simplifying the dissect_nfs4_read_plus_content function
    to dissect only the contents of each item instead of the whole
    list and then use dissect_rpc_array function to dissect the
    array of content items.
    
    Bug: 16499
    Change-Id: Ia5c9929366cb35ab5d1646219c9b56f6051c4ff5
    Reviewed-on: https://code.wireshark.org/review/36861
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Petri-Dish: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  e74ce4e   Qt: Fix compilation error
     add  b1668e7   NFS: fix dissecting of READ_PLUS contents


Summary of changes:
 epan/dissectors/packet-nfs.c | 46 ++++++++++++--------------------------------
 1 file changed, 12 insertions(+), 34 deletions(-)