Wireshark-commits: [Wireshark-commits] master d5ec688: ColumnPreferencesFrame: fix memory leaks
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 19 Apr 2020 14:44:04 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=d5ec6882fe1122c9e7cae7a200322381584192a5
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

d5ec688 by Martin Kaiser (wireshark@xxxxxxxxx):

    ColumnPreferencesFrame: fix memory leaks
    
    Delete model and proxy model in the destructor.
    
    QAbstractItemView::setItemDelegate() does not take ownership of the delegate
    that is passed to it. We have to store it ourselves and free it.
    
    Change-Id: I5d08d16e94a162d2a25450aec05ef672d4eaf528
    Reviewed-on: https://code.wireshark.org/review/36878
    Reviewed-by: Martin Kaiser <wireshark@xxxxxxxxx>
    Petri-Dish: Martin Kaiser <wireshark@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  183a0df   dvb-ci: register the dissector by name
     add  d5ec688   ColumnPreferencesFrame: fix memory leaks


Summary of changes:
 ui/qt/column_preferences_frame.cpp | 6 +++++-
 ui/qt/column_preferences_frame.h   | 1 +
 2 files changed, 6 insertions(+), 1 deletion(-)