Wireshark-commits: [Wireshark-commits] master f0e834d: MAC-LTE: Use heuristic for length for DC PHR
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 17 Apr 2020 18:09:21 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=f0e834dfe862b0c78cdf52d687d18af1c2dda738
Submitter: "Martin Mathieson <martin.r.mathieson@xxxxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

f0e834d by Martin Mathieson (martin.mathieson@xxxxxxxxxxxx):

    MAC-LTE: Use heuristic for length for DC PHR CE
    
    Knowing how many bytes of C bits (1 or 4) relies
    upon knowing config that is not currently available
    to the dissector.  Instead, see if the length
    appears to match 1 byte, otherwise assume 4.
    
    Change-Id: I08f21ab23077ef3665d3fb78a1dc2db0b16bc481
    Reviewed-on: https://code.wireshark.org/review/36859
    Petri-Dish: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Martin Mathieson <martin.r.mathieson@xxxxxxxxxxxxxx>
    

Actions performed:

    from  3a1a64e   bacapp: don't call fTagHeader twice.
     add  f0e834d   MAC-LTE: Use heuristic for length for DC PHR CE


Summary of changes:
 epan/dissectors/packet-mac-lte.c | 321 ++++++++++++++++++++++++++++++++++++++-
 1 file changed, 315 insertions(+), 6 deletions(-)