Wireshark-commits: [Wireshark-commits] master 3d78523: USBLL: Set usbll_data_ptr to NULL on capture
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 17 Apr 2020 09:01:04 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=3d785236ae5d053ad04e10f94bb2fb196db2f287
Submitter: "Tomasz Moń <desowin@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

3d78523 by Ameya Deshpande (ameya.181co205@xxxxxxxxxxx):

    USBLL: Set usbll_data_ptr to NULL on capture file close
    
    As usbll_data_ptr is static variable, it was left pointing to
    last dissected packet details. The details were freed when
    capture file was closed.
    
    Prevent crash if first packet is Handshake packet and
    prev pointer is NULL.
    
    Change-Id: I03eef3afbfa679349fb2e9ce6d90c5f56b9515a0
    Signed-off-by: Ameya Deshpande <ameya.181co205@xxxxxxxxxxx>
    Reviewed-on: https://code.wireshark.org/review/36860
    Petri-Dish: Tomasz Moń <desowin@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Tomasz Moń <desowin@xxxxxxxxx>
    

Actions performed:

    from  73d2989   Qt: Remove unnecessary private variable
     add  3d78523   USBLL: Set usbll_data_ptr to NULL on capture file close


Summary of changes:
 epan/dissectors/packet-usbll.c | 87 ++++++++++++++++++++++--------------------
 1 file changed, 46 insertions(+), 41 deletions(-)