Wireshark-commits: [Wireshark-commits] master-3.2 ef50d8f: Qt: Fix a memory leak in ByteViewTab
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 13 Apr 2020 18:03:15 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=ef50d8f38888b0b052ea179c5cbcc06e7a11e25c
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master-3.2
Repository: wireshark

Commits:

ef50d8f by Stig Bjørlykke (stig@xxxxxxxxxxxxx):

    Qt: Fix a memory leak in ByteViewTab
    
    FieldInformation::parentField() allocated a new FieldInformation,
    so ensure to delete this when done.
    
    Change-Id: Id0f538cc696551ec47169103be823eb1e55d1777
    Reviewed-on: https://code.wireshark.org/review/36823
    Petri-Dish: Stig Bjørlykke <stig@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Martin Kaiser <wireshark@xxxxxxxxx>
    (cherry picked from commit 1f6449c05d70a8b1acf08b7c6795723c797e3ef5)
    Reviewed-on: https://code.wireshark.org/review/36827
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  5e0330c   extcap: Fix a memory leak
     add  ef50d8f   Qt: Fix a memory leak in ByteViewTab


Summary of changes:
 ui/qt/byte_view_tab.cpp | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)