Wireshark-commits: [Wireshark-commits] master-3.2 e46a3ea: SOMEIP: Bug fix for ignored length field
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 13 Apr 2020 17:50:09 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=e46a3ea2bcacfdacd500fad7d7e8c79916099f5b
Submitter: "Pascal Quantin <pascal@xxxxxxxxxxxxx>"
Changed: branch: master-3.2
Repository: wireshark

Commits:

e46a3ea by Dr. Lars Völker (lars.voelker@xxxxxxxxxxxxxxxxxxxxxxx):

    SOMEIP: Bug fix for ignored length field config on struct
    
    The length field of a struct can be configured to 0, 8, 16, or 32 bits.
    Independent of the config, it will always be ignored as set to 0 bits.
    This patch repairs this.
    
    Bug: 16490
    Change-Id: Idde3616ec06067363e767bd52bb5f443439c9aca
    Signed-off-by: Dr. Lars Völker <lars.voelker@xxxxxxxxxxxxxxxxxxxxxxx>
    Reviewed-on: https://code.wireshark.org/review/36770
    Petri-Dish: Pascal Quantin <pascal@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Pascal Quantin <pascal@xxxxxxxxxxxxx>
    Reviewed-on: https://code.wireshark.org/review/36830
    

Actions performed:

    from  9aafe3f   Qt: don't use a widget if not set.
     add  e46a3ea   SOMEIP: Bug fix for ignored length field config on struct


Summary of changes:
 epan/dissectors/packet-someip.c | 48 ++++++++++++++++++++++++++++++++---------
 1 file changed, 38 insertions(+), 10 deletions(-)